🐛 Add cancel context to NewGRPCClient (#720) #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![konveyor-ci-bot[bot]](https://avatars.githubusercontent.com/in/819470?s=60&v=4){kind=small}
### PR Summary Bug fix to address the issue of java-external-provider.exe not ending after analysis completion. Introduces a cancel context to the NewGRPCClient to ensure proper termination of the gRPC client. - provider/grpc/provider.go: Added context.WithCancel to manage the lifecycle of the gRPC client and ensure it can be properly stopped. - provider/grpc/provider.go: Updated grpcProvider struct to include cancelCmd and invoked cancelCmd() in the Stop method to terminate the context. Signed-off-by: kthatipally <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
dymurray
approved these changes
Dec 16, 2024
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Bug fix to address the issue of java-external-provider.exe not ending
after analysis completion.
Introduces a cancel context to the NewGRPCClient to ensure proper
termination of the gRPC client.
lifecycle of the gRPC client and ensure it can be properly stopped.
cancelCmd and invoked cancelCmd() in the Stop method to terminate the
context.
Signed-off-by: kthatipally [email protected]
Signed-off-by: Cherry Picker [email protected]